Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pypi search cleanup #120

Merged
merged 10 commits into from
Aug 21, 2023
Merged

Pypi search cleanup #120

merged 10 commits into from
Aug 21, 2023

Conversation

airportyh
Copy link
Contributor

Why

Found some cleanup to do aftermath of #119.

Changes

  1. no need to use sqlite for search functionality. Therefore removing downloads field.
  2. in findNode(node, want): don't drilldown to child nodes if target node is found, save some CPU

@airportyh airportyh requested a review from a team as a code owner August 21, 2023 15:31
@airportyh airportyh requested review from cdmistman and removed request for a team August 21, 2023 15:31
@airportyh airportyh merged commit bf48909 into main Aug 21, 2023
@airportyh airportyh deleted the th-pypi-search-cleanup branch August 21, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

@cdmistman cdmistman Awaiting requested review from cdmistman cdmistman is a code owner automatically assigned from replit/devex

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@airportyh @ryantm @blast-hardcheese