Remove x/crypto package, use x/term #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantm
approved these changes
Oct 13, 2023
go.mod
Outdated
| @@ -12,8 +12,8 @@ require ( | |||
| github.com/smacker/go-tree-sitter v0.0.0-20230501083651-a7d92773b3aa | |||
| github.com/spf13/cobra v0.0.5 | |||
| github.com/stretchr/testify v1.8.1 | |||
| golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9 | |||
| golang.org/x/net v0.5.0 | |||
| golang.org/x/crypto v0.14.0 | |||
There was a problem hiding this comment.
I think we can remove x/crypto after this. It only was used in table.go.
There was a problem hiding this comment.
Oh, for some reason I thought crypto/md5 comes from that, but it's part of standard lib. Will fix, nice catch.
masad-frost
force-pushed
the
fm-update-crypto
branch
from
b378e87
to
95bc2ff
Compare
masad-frost
changed the title
masad-frost
force-pushed
the
fm-update-crypto
branch
from
bf33cc2
to
a082adf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #97
What changed
Test plan
upm search -l nodejs-npm --format table leftpad