[python map] normalize #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why === * There were cases where you'd install two python libraries and get two different versions of ffmpeg or imagemagick What changed === * I manually went through and picked the largest of packages where there might be minimal and full verison, and where there was a specific version of something, I used the default version. Note, this might not be correct in some cases, but it is likely to be an okay first approximation Test plan === * I confirmed the python map is still valid json by passing it through jq * We'll let this cool in Explorer for a while.
airportyh
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
What changed
Test plan
go test -v ./internal/nix/...passes