lock when there isnt a package dir either #214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
There's still some scenarios when
upm lock
doesn't happen. Right now the heuristic is:--force
flag is passedWe should also run if the package dir doesn't exist
What Changed
if the 3 above conditions are all false, then also check to see if
backend.GetPackageDir()
returns a path, and if that path doesn't exist.Testing
test suite :)
for manual testing:
rm -rdf node_modules
if it existsupm lock
should recreate thenode_modules
dir