Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/Scrutinize pyproject for backends #234

Merged

Conversation

blast-hardcheese
Copy link
Collaborator

@blast-hardcheese blast-hardcheese commented Feb 14, 2024

Why

In cases where users are using pyproject.toml for more than just Poetry, we should permit pip + pyproject to coexist.

What changed

  • Introduced an optional IsSpecfileCompatible to analyze the contents of a specfile to confirm compatibility. Currently exclusively for poetry, but this could extend to package.json as well

Test plan

HD73VL2GVX:pyprpip dstewart$ cat pyproject.toml
[build-system]
requires = ["setuptools"]
build-backend = "setuptools.build_meta"

HD73VL2GVX:pyprpip dstewart$ upm lock
could not autodetect a language for your project

HD73VL2GVX:pyprpip dstewart$ touch requirements.txt

HD73VL2GVX:pyprpip dstewart$ upm lock
--> pip install -r requirements.txt
...

@blast-hardcheese blast-hardcheese requested a review from a team as a code owner February 14, 2024 21:21
@blast-hardcheese blast-hardcheese requested review from cdmistman and removed request for a team February 14, 2024 21:21
Copy link
Collaborator

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, good. Added a nit about the function name.

internal/api/types.go Outdated Show resolved Hide resolved
@blast-hardcheese blast-hardcheese force-pushed the dstewart/chore/scrutinize-pyproject-for-backends branch from 4e99d9f to eff7c2b Compare February 14, 2024 21:29
@blast-hardcheese blast-hardcheese enabled auto-merge (squash) February 14, 2024 21:30
Copy link
Contributor

@cdmistman cdmistman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, makes sense

@blast-hardcheese blast-hardcheese merged commit f33424b into main Feb 14, 2024
3 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/chore/scrutinize-pyproject-for-backends branch February 14, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants