Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] If packageDir does not exist, run Install #235

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

blast-hardcheese
Copy link
Collaborator

Why

During testing, rm -rf .pythonlibs followed by a Run skips package install completely:

Turns out this is because we don't verify the package directory actually exists

~/2024-02-15-venv-test$ upm show-package-dir
/home/runner/2024-02-15-venv-test/.pythonlibs
~/2024-02-15-venv-test$ du -sh $(upm show-package-dir)
du: cannot access '/home/runner/2024-02-15-venv-test/.pythonlibs': No such file or directory

What changed

  • If the package directory isn't present, ignore the cache and run install.

Test plan

@blast-hardcheese blast-hardcheese requested a review from a team as a code owner February 15, 2024 20:58
@blast-hardcheese blast-hardcheese requested review from airportyh and removed request for a team February 15, 2024 20:58
Copy link
Collaborator

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think I've hit this before long ago.

@blast-hardcheese blast-hardcheese merged commit a040336 into main Feb 15, 2024
3 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/bug/run-install-if-packageDir-missing branch February 15, 2024 21:48
@blast-hardcheese blast-hardcheese added the bug Something isn't working label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants