Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override for jwt/PyJWT #243

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

blast-hardcheese
Copy link
Collaborator

Why

PyJWT and jwt share the same namespace.

What changed

If a user uses PyJWT, do not also install jwt.

Test plan

$ upm add pyjwt
$ echo import jwt > main.py
$ upm guess  # should not print anything

@blast-hardcheese blast-hardcheese requested a review from a team as a code owner March 14, 2024 00:11
@blast-hardcheese blast-hardcheese requested review from cdmistman and removed request for a team March 14, 2024 00:11
Copy link
Contributor

@airportyh airportyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blast-hardcheese blast-hardcheese merged commit 0708c25 into main Mar 18, 2024
3 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/bug/pyjwt-override branch March 18, 2024 19:29
@blast-hardcheese blast-hardcheese added the bug Something isn't working label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants