Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/Reflow test populator #283

Merged
merged 7 commits into from
Aug 30, 2024

Conversation

blast-hardcheese
Copy link
Collaborator

Why

To support #244, do some housekeeping.

What changed

  • Reorganize python/python.go. Reduce spaghetti by a bit.
  • We shouldn't care about how to populate a project during tests. We know the files are embedded, we can recurse the directories and copy the files into a target. All this file path juggling is unnecessary.

Test plan

CI should still pass

@blast-hardcheese blast-hardcheese requested a review from a team as a code owner August 30, 2024 18:30
@blast-hardcheese blast-hardcheese requested review from vlinkz and removed request for a team August 30, 2024 18:30
@blast-hardcheese blast-hardcheese force-pushed the dstewart/chore/reflow-test-populator branch 2 times, most recently from 67fa6f5 to 7fea7fe Compare August 30, 2024 19:15
Copy link
Collaborator

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@blast-hardcheese blast-hardcheese merged commit aebeec3 into main Aug 30, 2024
3 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/chore/reflow-test-populator branch August 30, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants