Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional debugging output #579

Closed
wants to merge 2 commits into from
Closed

Add additional debugging output #579

wants to merge 2 commits into from

Conversation

jftanner
Copy link

@jftanner jftanner commented May 2, 2022

This PR adds some debugging output for when context.config returns an empty object (or null). This resulted from #566, where I had neglected to set GHE_HOST so Octokit called public Github instead of GHE. Hopefully this debugging helps future users identify the same situation.

@vercel
Copy link

vercel bot commented May 2, 2022

@jftanner is attempting to deploy a commit to the Probot Team on Vercel.

A member of the Team first needs to authorize it.

@travi
Copy link
Member

travi commented May 4, 2022

is there documentation that would be worth linking to in this log output that would have given hints toward why the config was unable to be read?

@jftanner
Copy link
Author

jftanner commented May 5, 2022

That's a good question. This is the relevant documentation: https://probot.github.io/docs/configuration/

Though, maybe I should add an additional check that verifies that the URLs in the webhook payload match GHE_HOST variable. That'd be a known failure state with a known fix, whereas there might be other reasons why context.config might fail.

@jftanner
Copy link
Author

jftanner commented May 5, 2022

I've added that change. Unfortunately, I can't test it properly because I'm stuck on an unrelated problem with ESM.

@jftanner jftanner closed this by deleting the head repository Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants