bn.js and Web3 typings fix #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue with Web3 shipping with bad typings, and also adds some tests for opening and closing of orders.
Motivation
When users start a Typescript project, the
bn.d.tsfile used by the SDK file is not shipped with the SDK. This results in the user having many issues with the bn.js library.Design
In the later versions of web3.js incorrect typings are no longer shipped so we can update the web3.js and use the
@types/web3package instead. However there are breaking changes in the new version of web3 and typings need to be updated. This PR updates the bindings in thecontracts/bindings/folder and also updates the methods to convert values to a hexadecimal string before interacting with web3. See this issue for details.