-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reqnroll Extension v2024.3.152 does not work on Visual Studio 17.11.4 #37
Comments
Debugging the Visual Studio Extension locally, it seems to work fine on commit #e22. Might be something to do with updating dependencies @gasparnagy on #41a? |
thanks guys for being so quick on this. Meanwhile, is there a way I can get 2024.2.93 version? |
Was just adding the steps for that to this ticket, so see above. |
amazing. I just tried it. All works absolutely fine now :) Thanks again @UL-ChrisGlew |
@gasparnagy I'm seeing the below in the activity log when loading a project, could be related: |
The issue is not reproducible on my machine (I have just upgraded to Visual Studio 17.11.4), so I decided to apply a hotfix and reverted the commit that is most probably causing the problem. My plan is to release this ASAP and diagnose & fix the original issue without the stress of users being blocked. I need help:
|
@gasparnagy - Tested that VSIX file, seems to fix the issue. One thing I did notice with the previous version is that the version of System.IO.Abstractions we're now using has dependencies on other NuGet packages (TestableIO.System.IO.Abstractions and TestableIO.System.IO.Abstractions.Wrappers), which had assemblies missing from the extensions directory - possible there's more than just these missing? |
@UL-ChrisGlew thx for the quick reaction. The hotfix (v2024.4.154) is currently being published, it will be available in the marketplace within a few minutes. It can be that the package is just simply missing some additional assemblies, and maybe I have some other extension that deployed that and that is why it is not reproducible here. |
@gasparnagy Works for me too |
Possibly yes, I did have to test this on another machine with just that Reqnroll extension installed in order to see what's going on with this. Unfortunately the code is a bit of out my wheelhouse so I'm not 100% confident in figuring out what's going on - I'll try and have another look though. |
v2024.3.152 also had the same described issue on our side. Can confirm that the hotfix (v2024.4.154) is working as expected. |
hotfix (v2024.4.154) works for me |
I've managed to 'fix' and replicate a before/after with the PR #39. Testing done:
It's obviously a bit risky as it's very tricky to get error output/etc from these sort of changes - but given the error I was seeing in the ActvityLog.xml has dissappeared - it's doing something right at least! EDIT 🤦, forgot that the changes were reverted into main - will have do some more digging! |
@gasparnagy I've had a play around and the extension does seem to work correctly with all updates re-applied and the missing files added back. Have re-raised #39 for review. |
There is a CI build now that contains the proper fix by @UL-ChrisGlew, and I would like to release this soon to address the security issues. To avoid the situation we had last time, @orifn1, @jdb0123, @JimCooperFromGmailAccount could you please help trying it out with the VSIX of this CI build downloadable from here. If it works, you can even keep it installed. It is basically the released version plus the problematic package updates. |
|
I'm having a very strange issue installing that extension from the VSIX file - the VSIX is installed (I can see the files in the relevant folder), but VS 2022 isn't recognising it as installed. |
@UL-ChrisGlew Funny. Try to uninstall completely. Start VS. Wait until uninstall finished. Start VS again (so it updates caches). Close it again and after that try installing it from VSIX again. |
I had that with the 152 update. VS gets a wee bit confused from time to time :-)
Uninstall it (it took 2 tries for me) and reinstall and it gets VS back to normal
… On 19 Sep 2024, at 11:37, Chris Glew ***@***.***> wrote:
I'm having a very strange issue installing that extension from the VSIX file - the VSIX is installed (I can see the files in the relevant folder), but VS 2022 isn't recognising it as installed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Looks good for me too
… On 19 Sep 2024, at 11:25, Gáspár Nagy ***@***.***> wrote:
There is a CI build now that contains the proper fix by @UL-ChrisGlew, and I would like to release this soon to address the security issues. To avoid the situation we had last time, @orifn1, @jdb0123, @JimCooperFromGmailAccount could you please help trying it out with the VSIX of this CI build downloadable from here.
If it works, you can even keep it installed. It is basically the released version plus the problematic package updates.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Yeah, I've tried uninstalling the extension completely, then installing from the Extensions manager - and updating the VSIX from the file provided and no dice - just won't show up in Visual Studio :/ |
Okay, redownloaded the file and tried again and it worked okay - must have been a duff download 🤷 @gasparnagy - seems to work okay for me now |
Thx. Just for the record, sometimes in stange installation problems you can also try |
Used Visual Studio
Visual Studio 2022
Are the latest Visual Studio updates installed?
Yes
Content of reqnroll.json (if present)
No response
Issue Description
When attempting to load a Reqnroll project on the latest version of Visual Studio 2022 with the latest Reqnroll extension installed, the extension will not load and functionality is not present.
Steps to Reproduce
Workaround
We have issued a hotfix, to the simplest workaround is to update the package to v2024.4.154 that should work.
An alternative workaround for this issue would be to downgrade the Visual Studio 2022 extension to the previous version.
The download for the previous version can be found here:
https://marketplace.visualstudio.com/_apis/public/gallery/publishers/Reqnroll/vsextensions/ReqnrollForVisualStudio2022/2024.2.93/vspackage
To downgrade, you'll need to
The text was updated successfully, but these errors were encountered: