Adding missing assemblies.

[UL-ChrisGlew]

🤔 What's changed?

Adding missing dependency files:

• TestableIO.System.IO.Abstractions.dll
• TestableIO.System.IO.Abstractions.Wrappers.dll

That are now required due to an update in the System.IO.Abstractions package. I have tested this on an envrionment where #37 could be replicated. Tested both the broken VSIX file and one created with the lines ammended, which seems to function correctly.

⚡️ What's your motivation?

To fix #37

🏷️ What kind of change is this?

• 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

N/A

📋 Checklist:

• [*] Users should know about my change
  • [*] I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

---

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

[gasparnagy]

Fantastic. Thx for the quick analysis and fix. You are the hero of the day! 🤘

[gasparnagy]

@UL-ChrisGlew When you played with it locally, have you observed any issues with the Diagnostics.LoggingTests class from the unit test suite? We have a flaky error there, see #40.

[UL-ChrisGlew]

I hadn't initially - have re-run the unit tests a few times and had one test fail in that time due to #40 - so does seem to be a flaky error.

[UL-ChrisGlew]

I've just run them again and set to run until failure, and have not had any logging tests fail in 78 iterations - the failure that I have got was not related to logging:

[gasparnagy]

Hm... that is something else. From the "Specs" project there might be such errors sometimes - not good, but that are integration tests. But the worrying about the logger tests that they are unit tests, and (at least on the CI) more often happen. Just to double check: When you used "run until failure" have you done that for the Reqnroll.VisualStudio.Tests project?

One more: Could you please try to upgrade the ApprovalTests dependency to 6.0.0 and see if the flakiness comes for the logger tests?

[UL-ChrisGlew]

Yes, I've been running the whole Reqnroll.VisualStudio.Tests as 'Run until failure' and am not seeing any failures around those logging tests at the moment. I left just those logging tests running for ~500 iterations and they've not yet failed.

Have just updated the ApprovalTests package and ran again, failed after 11 iterations but I don't think it's related?

[gasparnagy]

I think it's just coincidence, but who knows...

[gasparnagy]

This particular error I have seen already a few times already in SpecFlow times...

[UL-ChrisGlew]

Ran again and have a different failure:

Again, don't think this is related?

[gasparnagy]

Hm... Maybe these are also more frequent now. Anyhow. It seems we have quite some flakiness in our tests, so we will need to dig into these one after the other...

Maybe what happened is that the unit test framework has been improved to run the test parallel slightly differently, and now more of these come up.

[gasparnagy]

The question is whether we should wait with releasing the fixed dependencies. Because these seem to be more of testing issues and not related to the product itself.

[UL-ChrisGlew]

I don't think it's related to the fixed dependencies - have just checked out the project prior to the package updates going through and am still getting some sporadic failures in the unit tests:

[gasparnagy]

OK. Could you please copy this last comment to #40 and let's track the flaky problems there.