Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locale strings (and some missing strings) for group view #6816

Open
wants to merge 5 commits into
base: vega
Choose a base branch
from

Conversation

MangaOtaku
Copy link

No description provided.

Mangaokaku added 2 commits November 6, 2023 14:40
Comment on lines 335 to +342
"admin.groups.permissions": "Permissions",
"admin.groups.permissions.adminHint": "Can access the administration area.",
"admin.groups.permissions.userHint": "Can create / manage users (but not users with administrative permissions)",
"admin.groups.permissions.groupHint": "Can create / manage groups and assign permissions (but not manage:system) / page rules",
"admin.groups.permissions.navigationHint": "Can manage site navigation",
"admin.groups.permissions.themeHint": "Can modify site theme settings",
"admin.groups.permissions.sitesHint": "Can create / manage sites",
"admin.groups.permissions.systemHint": "Can manage and access everything. Root administrator.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't add sub-keys to a key that already has a value.

Subsequent keys should instead use the format admin.groups.permissionsAdminHint

Comment on lines +365 to +394
"admin.groups.rules.read.pages.hint": "Can view and search pages.",
"admin.groups.rules.read.pages.title": "Read Pages",
"admin.groups.rules.write.pages.hint": "Can create and edit pages.",
"admin.groups.rules.write.pages.title": "Write Pages",
"admin.groups.rules.review.pages.hint": "Can review and approve edits submitted by users.",
"admin.groups.rules.review.pages.title": "Review Pages",
"admin.groups.rules.manage.pages.hint": "Can move existing pages to other locations the user has write access to.",
"admin.groups.rules.manage.pages.title": "Manage Pages",
"admin.groups.rules.delete.pages.hint": "Can delete existing pages.",
"admin.groups.rules.delete.pages.title": "Delete Pages",
"admin.groups.rules.write.styles.hint": "Can insert CSS styles in pages.",
"admin.groups.rules.write.styles.title": "Use CSS",
"admin.groups.rules.write.scripts.hint": "Can insert JavaScript in pages.",
"admin.groups.rules.write.scripts.title": "Use JavaScript",
"admin.groups.rules.read.source.hint": "Can view pages source.",
"admin.groups.rules.read.source.title": "View Page Source",
"admin.groups.rules.read.history.hint": "Can view previous versions of pages.",
"admin.groups.rules.read.history.title": "View Page History",
"admin.groups.rules.read.assets.hint": "Can view / use assets (such as images and files) in pages.",
"admin.groups.rules.read.assets.title": "View Assets",
"admin.groups.rules.write.assets.hint": "Can upload new assets (such as images and files).",
"admin.groups.rules.write.assets.title": "Upload Assets",
"admin.groups.rules.manage.assets.hint": "Can edit and delete existing assets (such as images and files).",
"admin.groups.rules.manage.assets.title": "Manage Assets",
"admin.groups.rules.read.comments.hint": "Can view page comments.",
"admin.groups.rules.read.comments.title": "Read Comments",
"admin.groups.rules.write.comments.hint": "Can post new comments on pages.",
"admin.groups.rules.write.comments.title": "Write Comments",
"admin.groups.rules.manage.comments.hint": "Can edit and delete existing page comments.",
"admin.groups.rules.manage.comments.title": "Manage Comments",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. use camelCase instead of dots, e.g. admin.groups.ruleReadPagesHint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants