Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing HTTPS options that were not being passed to tunnel #1380

Merged
merged 2 commits into from
Feb 2, 2015
Merged

Add missing HTTPS options that were not being passed to tunnel #1380

merged 2 commits into from
Feb 2, 2015

Conversation

brichard19
Copy link
Contributor

Sorry I had to make another pull request - I fudged up when doing a rebase :(

-This change adds some missing HTTPS options that were not being passed to the tunnel module.
-Updated test-tunnel.js to include tests for mutual TLS over HTTP tunnel

This fixes Issue 1259 where the user is prompted for the private key password when performing mutual authentication using a tunnel proxy with a password-protected private key.

@nylen
Copy link
Member

nylen commented Jan 26, 2015

You have a few lint errors. Other than that, it looks good at a glance, and I'll do a more detailed review tomorrow.

@nylen nylen changed the title [FIXED] Add missing HTTPS options that were not being passed to tunnel Add missing HTTPS options that were not being passed to tunnel Jan 26, 2015
@nylen nylen merged commit cb6cb78 into request:master Feb 2, 2015
@nylen
Copy link
Member

nylen commented Feb 2, 2015

Version 2.52.0 is out on npm with this change (via #1383).

@nylen
Copy link
Member

nylen commented Feb 2, 2015

Use 2.53.0 instead (see #1395, #1396).

@brichard19 brichard19 deleted the upstream branch February 3, 2015 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants