Skip to content

Commit

Permalink
Comment/issue about string-interning
Browse files Browse the repository at this point in the history
  • Loading branch information
jleibs committed Oct 11, 2024
1 parent 95e98bc commit 281a034
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions crates/store/re_chunk_store/src/dataframe.rs
Original file line number Diff line number Diff line change
Expand Up @@ -795,6 +795,8 @@ impl ChunkStore {
selector: &ComponentColumnSelector,
) -> ComponentColumnDescriptor {
// Happy path if this string is a valid component
// TODO(#7699) This currently interns every string ever queried which could be wasteful, especially
// in long-running servers. In practice this probably doesn't matter.
let direct_component = ComponentName::from(selector.component_name.clone());

let component_name = if self.all_components().contains(&direct_component) {
Expand Down

0 comments on commit 281a034

Please sign in to comment.