Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manually setting full span scopes #6509

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jun 5, 2024

What

When #6491 migrated to using UiStack for full span scopes, it wasn't possible to manually set a full span scope somewhere. Because of that, a clip rect hack was used for the streams tree. With emilk/egui#4617, it's now possible to support that correctly, so this PR introduces UiExt::full_span_scope() and uses it for the streams tree.

This PR also bumps the egui/egui_commonmark/egui_tiles commits.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added ui concerns graphical user interface include in changelog labels Jun 5, 2024
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@emilk
Copy link
Member

emilk commented Jun 5, 2024

The PR number didn't get updated, but it got built: https://rerun.io/viewer/pr/6509?manifest_url=https://app.rerun.io/version/main/examples_manifest.json

and it works!

@emilk emilk merged commit b0b26ad into main Jun 5, 2024
36 of 38 checks passed
@emilk emilk deleted the antoine/full-span-scope branch June 5, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants