Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native H.264 decoding using FFMPEG over CLI/IPC #7658

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 9, 2024

What

TODO

  • Add watchdog to restart ffmpeg if it dies (e.g. due to pkill)
  • Check if ffmpeg is installed once, and then add helpful error message if not
  • Fix all remaining TODOs

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video labels Oct 9, 2024
@emilk emilk mentioned this pull request Oct 9, 2024
6 tasks
@emilk emilk force-pushed the emilk/ffmpeg-decoder branch 2 times, most recently from 56e6539 to 43037fa Compare October 9, 2024 14:21
Copy link

github-actions bot commented Oct 9, 2024

Deployed docs

Commit Link
43037fa https://landing-owgu25rqv-rerun.vercel.app/docs

emilk added a commit that referenced this pull request Oct 10, 2024
### What
Some small improvements in service of coming ffmpeg stuff

* Extracted from #7658
* Part of #7606

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7660?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7660?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7660)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native H.264
1 participant