Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Linux build: Make the nasm feature a no-op #7675

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Fix Linux build: Make the nasm feature a no-op #7675

merged 5 commits into from
Oct 10, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 10, 2024 •
edited by github-actions bot
Loading

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🐧 linux Linux-specific problems exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI 🎞️ video labels Oct 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2024 •
edited
Loading

Deployed docs

Commit Link
d775449 https://landing-n134f3a3q-rerun.vercel.app/docs

@emilk
Copy link
Member Author

emilk commented Oct 10, 2024

@rerun-bot full-check

@github-actions GitHub Actions
Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/11272267771

jprochazk
jprochazk approved these changes Oct 10, 2024
View reviewed changes
crates/store/re_video/Cargo.toml Outdated Show resolved Hide resolved
crates/top/rerun-cli/Cargo.toml Outdated Show resolved Hide resolved
crates/top/rerun/Cargo.toml Outdated Show resolved Hide resolved
rerun_py/Cargo.toml Outdated Show resolved Hide resolved
@emilk
Copy link
Member Author

emilk commented Oct 10, 2024

main build still fails because of --all-features… maybe I'll do a different fix

@emilk emilk marked this pull request as draft October 10, 2024 10:50
@emilk
Copy link
Member Author

emilk commented Oct 10, 2024

@rerun-bot full-check

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2024 •
edited by emilk
Loading

✅ Started a full build: https://github.com/rerun-io/rerun/actions/runs/11272606090

@emilk emilk changed the title Do not compile with nasm by default Fix Linux build: Make the nasm feature a no-op Oct 10, 2024
@emilk emilk marked this pull request as ready for review October 10, 2024 10:57
@emilk emilk merged commit 8df29e2 into main Oct 10, 2024
67 checks passed
@emilk emilk deleted the emilk/no-nasm-no-cry branch October 10, 2024 11:49
@Wumpf Wumpf mentioned this pull request Oct 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprochazk jprochazk jprochazk approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🐧 linux Linux-specific problems 🚢 CI 🎞️ video
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @jprochazk