Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow component selectors to be specified as strings with flexible matching #7695

Merged
merged 9 commits into from
Oct 11, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 11, 2024

What

This means you can now do:

view = self.recording.view(index="my_index", contents={"points": "position3D"}).select("position3d")

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added 🐍 Python API Python logging API feat-dataframe-api Everything related to the dataframe API labels Oct 11, 2024
@jleibs jleibs marked this pull request as ready for review October 11, 2024 14:43
@@ -793,13 +794,36 @@ impl ChunkStore {
&self,
selector: &ComponentColumnSelector,
) -> ComponentColumnDescriptor {
// Happy path if this string is a valid component
let direct_component = ComponentName::from(selector.component_name.clone());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I guess that means we're going to intern a bunch of random strings indefinitely.

This is hardly a problem in practice, but might deserve a NOTE.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: #7699

@jleibs jleibs merged commit 0045de5 into main Oct 11, 2024
35 of 36 checks passed
@jleibs jleibs deleted the jleibs/dataframe_component_promotion branch October 11, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat-dataframe-api Everything related to the dataframe API include in changelog 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add automatic promotion of "Component" to "rerun.components.Component"
2 participants