Update GitHub links #793
Merged
Update GitHub links #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DZakh
commented
Jan 11, 2024
| @@ -16,7 +16,7 @@ let linkOrActiveApiSubroute = (~route) => { | |||
| } | |||
| } | |||
|
|
|||
| let githubHref = "https://github.com/reason-association/rescript-lang.org#rescript-langorg" | |||
There was a problem hiding this comment.
Link to the page instead of the header in README
There was a problem hiding this comment.
I wonder what @ryyppy thinks about this one
There was a problem hiding this comment.
sure, as long as its clear on how to contribute to the docs.
fhammerschmidt
approved these changes
Jan 11, 2024
DZakh
force-pushed
the
fix-github-link
branch
from
fb83ea0
to
af5da21
Compare
|
@DZakh is attempting to deploy a commit to the ReScript Association Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still some links to the old
reason-associationname in the block posts left. Should I update them torescript-associationas well?