Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the problem is with JS minification. Fixed by disabling
swcMinify
innext.config.mjs
Compiled JS for
CompilerManagerHook.Semver
moduleThis is
Semver
module minified.Semver
has two functionsparse
andtoString
.See that the
toString
function is not in theea
objectWe also have a
getCompilerUrl
function inCompilerManagerHook.res
that usesCompilerManagerHook.Semver.toString
The compiled js for
getCompilerUrl
below. See that it callsei(e)
which is theSemver.toString
functionSearch for
function ei
we found theSemver.toString
minifiedBut where
Semver.toString
is called to return a string it callsea.toString
, buttoString
does not exist in the objecthttps://github.com/rescript-association/rescript-lang.org/blob/e407ce1e72ecaabf7a52f2e4819c5b037123f43c/src/Playground.res#L989
Node example:
Related #844