Setup requirment bug #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagarvora
commented
May 7, 2024
|
|
||
| bench = Bench( | ||
| bench_path | ||
| ) # DOUBT : why __init__'s last 3 object initialization not happen? |
There was a problem hiding this comment.
Bench __init__ has only one parameter:
https://github.com/frappe/bench/blob/921957ccb21398e70dcc7172587f99624e83c35b/bench/bench.py#L60
sagarvora
commented
May 7, 2024
| @@ -172,7 +172,7 @@ def get_current_branch(app, bench_path="."): | |||
| from bench.utils import get_cmd_output | |||
|
|
|||
| repo_dir = get_repo_dir(app, bench_path=bench_path) | |||
| return get_cmd_output("basename $(git symbolic-ref -q HEAD)", cwd=repo_dir) | |||
| return get_cmd_output("git symbolic-ref -q --short HEAD", cwd=repo_dir) | |||
There was a problem hiding this comment.
is this change necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for review only