fix: Nan value when no items

resilient-tech · Sep 4, 2024 · 7b982a8 · 7b982a8
1 parent f968037
commit 7b982a8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/india_compliance/gst_india/client_scripts/e_waybill_actions.js b/india_compliance/gst_india/client_scripts/e_waybill_actions.js
@@ -510,7 +510,7 @@ function get_sub_suppy_type_options(frm) {
     let supply_type, sub_supply_type, sub_supply_desc, document_type;
 
     if (frm.doctype === "Delivery Note") {
-        const same_gstin = frm.doc.billing_address_gstin === frm.doc.company_gstin;
+        const same_gstin = frm.doc.billing_address_gstin == frm.doc.company_gstin;
 
         if (frm.doc.is_return) {
             supply_type = "Inward";

diff --git a/india_compliance/public/js/taxes_controller.js b/india_compliance/public/js/taxes_controller.js
@@ -193,13 +193,13 @@ india_compliance.taxes_controller = class TaxesController {
             return (
                 total + multiplier * (item_wise_tax_rates[item.name] || tax_row.rate)
             );
-        }, 0);
+        }, 0) || 0;
     }
 
     calculate_total_taxable_value() {
         return this.frm.doc.items.reduce((total, item) => {
             return total + item.taxable_value;
-        }, 0);
+        }, 0) || 0;
     }
 
     get_value(field, doc, default_value) {