fix: update property setters for accounts settings and it's patch to …

…default it to billing address
resilient-tech · Oct 18, 2024 · ddfc99b · ddfc99b
1 parent ef52fb2
commit ddfc99b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/india_compliance/gst_india/setup/__init__.py b/india_compliance/gst_india/setup/__init__.py
@@ -239,10 +239,6 @@ def set_default_accounts_settings():
     """
     Accounts Settings overridden by India Compliance
 
-    - Determine Address Tax Category From:
-        This is overriden to be Billing Address, since that's the correct
-        address for determining GST applicablility
-
     - Automatically Add Taxes and Charges from Item Tax Template:
         This is overriden to be "No". Item Tax Templates are designed to have
         all GST Accounts and are primarily used for selection of tax rate.
@@ -252,11 +248,7 @@ def set_default_accounts_settings():
     show_accounts_settings_override_warning()
 
     frappe.db.set_single_value(
-        "Accounts Settings",
-        {
-            "determine_address_tax_category_from": "Billing Address",
-            "add_taxes_from_item_tax_template": 0,
-        },
+        "Accounts Settings", "add_taxes_from_item_tax_template", 0
     )
 
     frappe.db.set_default("add_taxes_from_item_tax_template", 0)

diff --git a/india_compliance/gst_india/setup/property_setters.py b/india_compliance/gst_india/setup/property_setters.py
@@ -83,7 +83,7 @@ def get_property_setters(*, include_defaults=False):
             "doctype": "Accounts Settings",
             "fieldname": "determine_address_tax_category_from",
             "property": "read_only",
-            "value": "1",
+            "value": "0",
         },
         {
             "doctype": "Accounts Settings",

diff --git a/india_compliance/patches.txt b/india_compliance/patches.txt
@@ -5,7 +5,7 @@ india_compliance.patches.v15.remove_duplicate_web_template
 [post_model_sync]
 india_compliance.patches.v14.set_default_for_overridden_accounts_setting
 execute:from india_compliance.gst_india.setup import create_custom_fields; create_custom_fields() #58
-execute:from india_compliance.gst_india.setup import create_property_setters; create_property_setters() #8
+execute:from india_compliance.gst_india.setup import create_property_setters; create_property_setters() #9
 execute:from india_compliance.income_tax_india.setup import create_custom_fields; create_custom_fields() #2
 india_compliance.patches.post_install.remove_old_fields #2
 india_compliance.patches.post_install.set_gst_tax_type