Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Extended E-Way Bill Support for Stock Entry #2594

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

Ninad1306
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 31.25000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 59.98%. Comparing base (c099283) to head (47727ee).
Report is 27 commits behind head on develop.

Files with missing lines Patch % Lines
.../gst_india/overrides/subcontracting_transaction.py 25.00% 12 Missing ⚠️
...ndia_compliance/gst_india/overrides/transaction.py 33.33% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2594      +/-   ##
===========================================
- Coverage    60.01%   59.98%   -0.03%     
===========================================
  Files          120      120              
  Lines        11537    11592      +55     
===========================================
+ Hits          6924     6954      +30     
- Misses        4613     4638      +25     
Files with missing lines Coverage Δ
...ia_compliance/gst_india/constants/custom_fields.py 100.00% <ø> (ø)
india_compliance/gst_india/utils/e_waybill.py 71.55% <100.00%> (ø)
...ndia_compliance/gst_india/overrides/transaction.py 88.15% <33.33%> (-0.93%) ⬇️
.../gst_india/overrides/subcontracting_transaction.py 29.12% <25.00%> (-0.30%) ⬇️

... and 17 files with indirect coverage changes

Impacted file tree graph

doc.taxes_and_charges = ""
doc.taxes = []

if not doc.purpose == "Material Transfer" or not doc.is_return:
Copy link
Contributor Author

@Ninad1306 Ninad1306 Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work standalone, as some fields in erpnext has to be updated in postprocess to correctly evaluate the conditions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference PR in ERPNext: frappe/erpnext#43061

if self.doc.doctype == "Delivery Note":
if self.doc.doctype == "Delivery Note" or (
self.doc.get("purpose") in ["Material Transfer", "Material Issue"]
and not self.doc.is_return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibility to use subcontracting order field

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subcontracting order is not a mandatory field in Stock Entry and also is not mandatory for e-Waybill Generation.
So using it may not be a differentiating factor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants