-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Extended E-Way Bill Support for Stock Entry #2594
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2594 +/- ##
===========================================
- Coverage 60.01% 59.98% -0.03%
===========================================
Files 120 120
Lines 11537 11592 +55
===========================================
+ Hits 6924 6954 +30
- Misses 4613 4638 +25
|
doc.taxes_and_charges = "" | ||
doc.taxes = [] | ||
|
||
if not doc.purpose == "Material Transfer" or not doc.is_return: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not work standalone, as some fields in erpnext has to be updated in postprocess to correctly evaluate the conditions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference PR in ERPNext: frappe/erpnext#43061
6957f33
to
d768fcb
Compare
aea54b9
to
5c94fbf
Compare
if self.doc.doctype == "Delivery Note": | ||
if self.doc.doctype == "Delivery Note" or ( | ||
self.doc.get("purpose") in ["Material Transfer", "Material Issue"] | ||
and not self.doc.is_return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possibility to use subcontracting order field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subcontracting order is not a mandatory field in Stock Entry and also is not mandatory for e-Waybill Generation.
So using it may not be a differentiating factor.
india_compliance/gst_india/overrides/subcontracting_transaction.py
Outdated
Show resolved
Hide resolved
india_compliance/gst_india/overrides/subcontracting_transaction.py
Outdated
Show resolved
Hide resolved
india_compliance/gst_india/overrides/subcontracting_transaction.py
Outdated
Show resolved
Hide resolved
25b86a2
to
a5ef21b
Compare
No description provided.