Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter for invalid invoice number in document issue summary #2641

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Sanket322
Copy link
Contributor

@Sanket322 Sanket322 commented Sep 27, 2024

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 61.33%. Comparing base (4bb9af2) to head (c2b011e).

Files with missing lines Patch % Lines
...nce/gst_india/doctype/gstr_1_beta/gstr_1_export.py 0.00% 4 Missing ⚠️
india_compliance/gst_india/report/gstr_1/gstr_1.py 75.00% 1 Missing ⚠️
...mpliance/gst_india/utils/gstr_1/gstr_1_json_map.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2641      +/-   ##
===========================================
- Coverage    61.33%   61.33%   -0.01%     
===========================================
  Files          119      119              
  Lines        11505    11517      +12     
===========================================
+ Hits          7057     7064       +7     
- Misses        4448     4453       +5     
Files with missing lines Coverage Δ
india_compliance/gst_india/utils/__init__.py 75.83% <100.00%> (+0.23%) ⬆️
india_compliance/gst_india/report/gstr_1/gstr_1.py 38.88% <75.00%> (+0.11%) ⬆️
...mpliance/gst_india/utils/gstr_1/gstr_1_json_map.py 69.55% <50.00%> (-0.07%) ⬇️
...nce/gst_india/doctype/gstr_1_beta/gstr_1_export.py 0.00% <0.00%> (ø)

Impacted file tree graph

@Sanket322 Sanket322 force-pushed the filter_invalid_invoice_in_doc_issue_summary branch from c2721f4 to 33d6a63 Compare October 2, 2024 10:16
@Sanket322 Sanket322 force-pushed the filter_invalid_invoice_in_doc_issue_summary branch from 33d6a63 to 7f1610a Compare October 2, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter for invalid invoice number in document issue summary(GSTR-1)
2 participants