Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace DurablePromise union type with single type #128

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

avillega
Copy link
Contributor

Implements the proposed change in
#126

@avillega avillega requested a review from dfarr June 26, 2024 22:23
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.47619% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.44%. Comparing base (7bf23ef) to head (4a05b1a).

Files Patch % Lines
lib/core/stores/remote.ts 81.25% 3 Missing ⚠️
lib/core/storages/withTimeout.ts 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   82.63%   82.44%   -0.19%     
==========================================
  Files          22       22              
  Lines        1399     1401       +2     
  Branches      381      356      -25     
==========================================
- Hits         1156     1155       -1     
+ Misses        243      240       -3     
- Partials        0        6       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avillega
Copy link
Contributor Author

The slight reduction in code coverage is expected.

@avillega avillega merged commit 4da10af into main Jun 27, 2024
2 checks passed
@avillega avillega deleted the avillega/refactor-durable-promise-types branch June 27, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants