Make locks for the top level function opt-in #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
==========================================
- Coverage 82.47% 79.94% -2.53%
==========================================
Files 17 17
Lines 1107 1107
Branches 300 309 +9
==========================================
- Hits 913 885 -28
- Misses 194 210 +16
- Partials 0 12 +12 ☔ View full report in Codecov by Sentry. |
dfarr
reviewed
Aug 23, 2024
| @@ -195,7 +195,8 @@ export class Resonate { | |||
| */ | |||
| async start(delay: number = 5000) { | |||
| clearInterval(this.#interval); | |||
| this.#_start(); | |||
| // await the first run of the recovery path to avoid races with the normal flow of the program | |||
| await this.#_start(); | |||
dfarr
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve the default experience during recovery,
and allows more advance use cases to use locks when necessary.