Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handleCompletePromise helper function #143

Merged
merged 1 commit into from
Aug 30, 2024

Commits on Aug 30, 2024

  1. Add handleCompletePromise helper function

    We had some code repetition around handling a completed durable promise.
    The repetition was fine, how ever this pattern will come to callbacks
    and tasks and we will have it in atleast 4 more places, having to
    write that code that many times is error prone and verbose.
    
    This change also fixes a bug made evident by this helper funciton where
    we were returning the value computed by the function directly instead of
    the value stored in the completed durable promise.
    avillega committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    f4e5d84 View commit details
    Browse the repository at this point in the history