Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add proto missing fields and add test for pkg/log #115

Merged
merged 3 commits into from
Nov 19, 2023

Conversation

dreamjz
Copy link
Contributor

@dreamjz dreamjz commented Nov 16, 2023

Solve #106

Description

  • Add missing fields for promise grpc response
  • Add unit test for pkg/log

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5efda2) 68.61% compared to head (0c4d281) 68.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   68.61%   68.69%   +0.07%     
==========================================
  Files          61       62       +1     
  Lines        6163     6178      +15     
==========================================
+ Hits         4229     4244      +15     
  Misses       1654     1654              
  Partials      280      280              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfarr
Copy link
Member

dfarr commented Nov 17, 2023

Thank you so much again @dreamjz !!! I wonder if we need to propagate these changes to the test harness in order for it to work.

@guergabo any inclination as to why the linearization test is failing?

@guergabo
Copy link
Contributor

guergabo commented Nov 17, 2023

99% percent sure its because i merged the test harness changes to adjust to the other PR before merging that PR. Let me get that merged in today and this should be good.

@guergabo guergabo force-pushed the feat-add-proto-missing-fields branch from 38bb039 to a770832 Compare November 19, 2023 16:58
@guergabo guergabo self-requested a review November 19, 2023 17:07
Copy link
Contributor

@guergabo guergabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @dreamjz for the blocker. Thanks for this amazing patch!

@guergabo guergabo merged commit dc3e0e2 into resonatehq:main Nov 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants