-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to search promises by tag #144
Conversation
Right now we will only permit for a search by a single tag at a time, used to implement invocation=true.
@@ -1,653 +0,0 @@ | |||
package service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed because these are duplicates of the http/grpc tests
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
+ Coverage 67.08% 67.29% +0.20%
==========================================
Files 76 76
Lines 7213 7308 +95
==========================================
+ Hits 4839 4918 +79
- Misses 2062 2071 +9
- Partials 312 319 +7 ☔ View full report in Codecov by Sentry. |
Optionally search by tags, if tags are provided all key/value pairs must match exactly. Example
Matches the promise:
But not the promise:
Additionally, we extract the tag
resonate:invocation
into a generated column and add an index on this column. This tag/column will be used to search for "top level" promises. This detail is not part of the promise specification and if not implemented will fall back to a standard tag search.