Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schedules): add schedules feature, refactor promise api #147

Merged
merged 32 commits into from
Dec 19, 2023
Merged

Conversation

guergabo
Copy link
Contributor

@guergabo guergabo commented Dec 12, 2023

CHANGES:

  • schedules cli commands
  • promise cli commands
  • schedules crud api
  • promises rest api refactor
  • schedule cron job coroutine
  • sqlite implementation
  • initial templated promise id with {{.timestamp}}
  • updated promise protos and openapi
  • dst for schedules crud
  • service unit testing
  • ignore codecov.yml

FOLLOW-UP PRs:

  • --data (base64) cannot disable or enable, --blob take whatever (fail differently).
  • util.write() + tests separate issue
  • update test harness
  • update docs with feature + new error messages
  • grpc support / update protos
  • requires updating sdks to use new promise API
  • dst schedulePromises coroutine
  • postgres (aio unit tests blocked by this, but coverage is covered by dst already)

DEPENDS ON:

@guergabo guergabo added the enhancement New feature or request label Dec 12, 2023
@guergabo guergabo self-assigned this Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 476 lines in your changes are missing coverage. Please review.

Comparison is base (23df570) 68.86% compared to head (e5a01be) 66.60%.

Files Patch % Lines
internal/app/coroutines/schedulePromises.go 25.92% 78 Missing and 2 partials ⚠️
internal/app/subsystems/aio/store/sqlite/sqlite.go 56.77% 56 Missing and 11 partials ⚠️
cmd/promise/complete_promise.go 0.00% 52 Missing ⚠️
internal/app/subsystems/api/service/schedule.go 60.52% 32 Missing and 13 partials ⚠️
cmd/promise/list_promises.go 0.00% 44 Missing ⚠️
internal/app/subsystems/api/http/schedule.go 0.00% 40 Missing ⚠️
cmd/promise/describe_promise.go 0.00% 30 Missing ⚠️
internal/app/coroutines/createSchedule.go 80.67% 18 Missing and 5 partials ⚠️
test/dst/model.go 63.15% 20 Missing and 1 partial ⚠️
cmd/promise/create_promise.go 79.31% 10 Missing and 2 partials ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   68.86%   66.60%   -2.27%     
==========================================
  Files          62       76      +14     
  Lines        6180     7214    +1034     
==========================================
+ Hits         4256     4805     +549     
- Misses       1645     2100     +455     
- Partials      279      309      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/schedule/record.go Outdated Show resolved Hide resolved
@guergabo guergabo changed the title feat(schedules): add gateway feature feat(schedules): add gateway features, refactor promise api Dec 18, 2023
@guergabo guergabo changed the title feat(schedules): add gateway features, refactor promise api feat(schedules): add schedules feature, refactor promise api Dec 18, 2023
@guergabo guergabo marked this pull request as ready for review December 19, 2023 00:47
@guergabo guergabo merged commit a83cb8f into main Dec 19, 2023
4 of 6 checks passed
@guergabo guergabo deleted the schedules branch December 19, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants