Refactor commands #167
Merged
Refactor commands #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
- Coverage 67.29% 66.08% -1.22%
==========================================
Files 76 78 +2
Lines 7308 7698 +390
==========================================
+ Hits 4918 5087 +169
- Misses 2071 2275 +204
- Partials 319 336 +17 ☔ View full report in Codecov by Sentry. |
guergabo
approved these changes
Dec 21, 2023
| @@ -53,7 +53,7 @@ paths: | |||
| content: | |||
| application/json: | |||
| schema: | |||
| $ref: "#/components/schemas/PromiseList" | |||
| $ref: "#/components/schemas/PromiseSearchResponse" | |||
There was a problem hiding this comment.
let's update durable-promise repo with this new spec.
| @@ -108,7 +108,7 @@ func schedulePromise(tid string, schedule *schedule.Schedule) *scheduler.Corouti | |||
| Id: id, | |||
| State: state, | |||
| Param: schedule.PromiseParam, | |||
| Timeout: schedule.PromiseTimeout, | |||
| Timeout: crontime + schedule.PromiseTimeout, | |||
| cmd.Println(string(promise)) | ||
| } | ||
| } else { | ||
| prettyPrintPromises(cmd, *resp.JSON200.Promises...) |
There was a problem hiding this comment.
nit: smart formatting thing. let's do if { return } prett instead of if else{} more idiomatic and nicer to read. would love this standard for this repo in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the serve and dst commands to conform to new style.
Additionally: