Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add grpc support for schedules api #175

Merged
merged 12 commits into from
Jan 3, 2024
Merged

add grpc support for schedules api #175

merged 12 commits into from
Jan 3, 2024

Conversation

guergabo
Copy link
Contributor

@guergabo guergabo commented Dec 28, 2023

Changes:

  • grpc support for schedules api
  • include headers for schedules
  • fix client api issue (stuck it in there)
  • re-enable test harness
  • remove inline in openapi for resuability and removing anonymous structs (search queries are find since just strings and single usage)

@guergabo guergabo self-assigned this Dec 28, 2023
@guergabo guergabo added the enhancement New feature or request label Dec 28, 2023
@guergabo guergabo changed the title Fix api add grpc support for schedules api Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 492 lines in your changes are missing coverage. Please review.

Comparison is base (d550104) 66.77% compared to head (7202dfb) 64.19%.
Report is 1 commits behind head on main.

Files Patch % Lines
...nternal/app/subsystems/api/grpc/api/schedule.pb.go 27.59% 379 Missing and 4 partials ⚠️
...al/app/subsystems/api/grpc/api/schedule_grpc.pb.go 57.14% 33 Missing and 12 partials ⚠️
internal/app/subsystems/api/grpc/schedule.go 65.38% 28 Missing and 8 partials ⚠️
...nal/app/subsystems/api/grpc/api/promise_grpc.pb.go 72.34% 13 Missing ⚠️
internal/app/subsystems/api/http/schedule.go 33.33% 6 Missing and 2 partials ⚠️
cmd/util/util.go 0.00% 6 Missing ⚠️
cmd/promises/get.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   66.77%   64.19%   -2.58%     
==========================================
  Files          80       83       +3     
  Lines        8052     8807     +755     
==========================================
+ Hits         5377     5654     +277     
- Misses       2320     2772     +452     
- Partials      355      381      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guergabo guergabo marked this pull request as ready for review January 1, 2024 15:49
api/promises-openapi.yml Outdated Show resolved Hide resolved
@guergabo guergabo requested a review from dfarr January 3, 2024 16:19
api/promises-openapi.yml Outdated Show resolved Hide resolved
api/schedules-openapi.yml Outdated Show resolved Hide resolved
api/schedules-openapi.yml Outdated Show resolved Hide resolved
cmd/promises/create.go Outdated Show resolved Hide resolved
@guergabo guergabo merged commit 3e177b0 into main Jan 3, 2024
5 of 7 checks passed
@guergabo guergabo deleted the fix-api branch January 3, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants