Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locks): add support for distributed locking #203

Merged
merged 15 commits into from
Jan 16, 2024
Merged

Conversation

guergabo
Copy link
Contributor

@guergabo guergabo commented Jan 11, 2024

Changes

based on design discussions with dominik.

  • Distributed Locks API Specs: openapi, proto
  • Distributed Lock API protocols: grpc, http
  • Distributed Locks Coroutines: AcquireLock, HeartbeatLocks, ReleaseLock, TimeoutLocks
  • Distributed Lock database support: sqlite, postgres
  • Testing: api unit testing, kernel deterministic simulation testing, aio unit testing

@guergabo guergabo added the enhancement New feature or request label Jan 11, 2024
@guergabo guergabo self-assigned this Jan 11, 2024
@guergabo guergabo changed the title feat(distributed-locks): first commit feat(distributed-locks): add support for distributed locking Jan 11, 2024
@guergabo guergabo marked this pull request as ready for review January 12, 2024 02:15
@guergabo guergabo changed the title feat(distributed-locks): add support for distributed locking feat(locks): add support for distributed locking Jan 12, 2024
@resonatehq resonatehq deleted a comment from codecov bot Jan 12, 2024
api/locks-openapi.yml Outdated Show resolved Hide resolved
api/locks-openapi.yml Outdated Show resolved Hide resolved
internal/kernel/t_api/api.go Outdated Show resolved Hide resolved
test/dst/model.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 483 lines in your changes are missing coverage. Please review.

Comparison is base (d4fb16c) 64.85% compared to head (53c0b34) 64.79%.
Report is 2 commits behind head on main.

Files Patch % Lines
internal/app/subsystems/api/grpc/api/lock.pb.go 34.66% 210 Missing and 3 partials ⚠️
...rnal/app/subsystems/aio/store/postgres/postgres.go 65.64% 31 Missing and 14 partials ⚠️
internal/app/subsystems/aio/store/sqlite/sqlite.go 65.64% 31 Missing and 14 partials ⚠️
internal/app/subsystems/api/http/lock.go 45.00% 27 Missing and 6 partials ⚠️
...ternal/app/subsystems/api/grpc/api/lock_grpc.pb.go 68.75% 19 Missing and 6 partials ⚠️
internal/app/subsystems/api/service/lock.go 76.00% 18 Missing and 6 partials ⚠️
internal/app/subsystems/api/grpc/lock.go 77.17% 16 Missing and 5 partials ⚠️
test/dst/model.go 76.66% 16 Missing and 5 partials ⚠️
internal/kernel/t_aio/store.go 0.00% 20 Missing ⚠️
internal/kernel/t_api/status.go 0.00% 10 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   64.85%   64.79%   -0.07%     
==========================================
  Files          83       94      +11     
  Lines        8829    10160    +1331     
==========================================
+ Hits         5726     6583     +857     
- Misses       2709     3120     +411     
- Partials      394      457      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guergabo guergabo requested a review from dfarr January 16, 2024 23:46
@guergabo guergabo merged commit 48477c2 into main Jan 16, 2024
5 of 7 checks passed
@guergabo guergabo deleted the distributed-locks branch January 17, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants