Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE 246] DST: Fault Injection #248

Merged
merged 9 commits into from
Mar 23, 2024
Merged

[ISSUE 246] DST: Fault Injection #248

merged 9 commits into from
Mar 23, 2024

Conversation

vaibhawvipul
Copy link
Contributor

@vaibhawvipul vaibhawvipul self-assigned this Mar 20, 2024
@vaibhawvipul vaibhawvipul linked an issue Mar 20, 2024 that may be closed by this pull request
[DST] Failure Injection #246
Closed
guergabo
guergabo approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@guergabo guergabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vaibhawvipul vaibhawvipul requested a review from dfarr March 21, 2024 15:11
dfarr
dfarr reviewed Mar 21, 2024
View reviewed changes
cmd/dst/run.go Outdated Show resolved Hide resolved
dfarr
dfarr approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@dfarr dfarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! Just want to wire the probability up to a command line flag for the dst command :)

@vaibhawvipul vaibhawvipul merged commit 60bda4a into main Mar 23, 2024
3 checks passed
@vaibhawvipul vaibhawvipul deleted the issue-246-vipul branch March 23, 2024 12:24
@vaibhawvipul vaibhawvipul restored the issue-246-vipul branch March 23, 2024 12:34
vaibhawvipul added a commit that referenced this pull request Mar 23, 2024
@vaibhawvipul
Revert "[ISSUE 246] DST: Fault Injection (#248)"
b1e115c 
This reverts commit 60bda4a.
@vaibhawvipul vaibhawvipul mentioned this pull request Mar 23, 2024
Merged
vaibhawvipul added a commit that referenced this pull request Mar 23, 2024
@vaibhawvipul
Revert "[ISSUE 246] DST: Fault Injection (#248)" (#251)
53b4b92 
This reverts commit 60bda4a.
@guergabo guergabo deleted the issue-246-vipul branch March 25, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guergabo guergabo guergabo approved these changes

@dfarr dfarr dfarr approved these changes

@dtornow dtornow Awaiting requested review from dtornow

Assignees

@vaibhawvipul vaibhawvipul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DST] Failure Injection
3 participants
@vaibhawvipul @dfarr @guergabo