Update lock timeout calculation on heartbeat #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the reqTime to calculate the new lock timeout on hearbeat. This is not perfect as cannot know the exact tick that the server updates the database, but the assertion in the release lock validation will be correct because we err on the side of under calculating the timeout time.
|
I diffed previously successful DST runs with seeds {0, 2, 3} to runs against this change and they produced the same logs. Previously unsuccessful dst run seeds {1, 31010} are fixed with this change. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
=======================================
Coverage 63.70% 63.71%
=======================================
Files 113 113
Lines 9718 9719 +1
=======================================
+ Hits 6191 6192 +1
Misses 3070 3070
Partials 457 457 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the reqTime to calculate the new lock timeout on hearbeat. This is not perfect as cannot know the exact tick that the server updates the database, but the assertion in the release lock validation will be correct because we err on the side of under calculating the timeout time.
Fixes #282
Fixes #283