-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gomod2nix.toml to codecov.yml ignore #292
Merged
guergabo
merged 1 commit into
resonatehq:main
from
lucperkins:codecov-remove-gomod2nix-toml
Apr 17, 2024
Merged
Add gomod2nix.toml to codecov.yml ignore #292
guergabo
merged 1 commit into
resonatehq:main
from
lucperkins:codecov-remove-gomod2nix-toml
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
=======================================
Coverage 58.46% 58.46%
=======================================
Files 113 113
Lines 9775 9775
=======================================
Hits 5715 5715
Misses 3693 3693
Partials 367 367 ☔ View full report in Codecov by Sentry. |
guergabo
added a commit
that referenced
this pull request
Apr 30, 2024
* Update release_verify_artifacts.yaml * Release 0.5 (#287) * Update release_verify_artifacts.yaml (#286) * Update release_verify_artifacts.yaml * Update README.md * build(deps): bump actions/checkout from 2 to 4 (#289) Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump google.golang.org/grpc from 1.62.1 to 1.63.2 (#290) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.62.1 to 1.63.2. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.62.1...v1.63.2) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add Nix flake for Resonate and use Nix extensively in CI (#291) * Add Nix flake for Resonate * Add an envrc file for direnv * Add missing version field to derivation * Add a Docker image output * Add CA certificates to Docker image * Add more comments to Docker image derivation * Add Nix usage docs to CONTRIBUTING.md * Add initial CI configuration * Infer version from Git rev * Add testing and coverage to Nix CI workflow * Add harness to flake and complete nix-cicd workflow * Nixify dst workflow * Fix name of harness binary * Add Nix to scan workflow * Restore test harness binary immediately prior to linearizability check * Nixify release artifacts workflow * Upload checksum for tarballs * Overwrite now-Nixified workflows * Restore explicit permissions to cicd workflow * Remove nix prefix from job names * Rework testing job by removing build job * Streamline check job * Streamline variable names in release workflow * Simplify flake output references in Nix commands * Provide separate step for building server and harness * Ignore Nix in codecov.yml * Add nix flake check to CI * Install Nix prior to flake check * Add gomod2nix support for package build * Add CI check to ensure gomod2nix.toml is up to date * Add gomod2nix docs and mockgen dependency to dev shell * Add docs on direnv * Add additional note on gomod2nix in CI * Opt for more idiomatic diff checking for gomod2nix.toml * Add gomod2nix.toml to codecov.yml ignore (#292) * Remove unnecessary chmod operations in CI (#293) * Standardize all Actions runners to ubuntu-22.04 (#294) * Build static binary on Linux with Nix (#295) * Use go build for dst workflow * Change step name * Add ldflags * Make resonate package static on Linux * Build with glibc on Linux * Update README.md * Update README.md * Add Actions workflow to update gomod2nix.toml (#297) * Add Actions workflow to update gomod2nix.toml * Update name of workflow * Update connections.go (#300) * Update connections.go * Add timeout to http client --------- Co-authored-by: Gabriel Guerra <[email protected]> * fix(release): workflow had small bugs here and there (#304) * Update release_publish_github_artifacts.yaml * Update release_publish_github_artifacts.yaml * Update release_publish_github_artifacts.yaml * Update release_publish_github_artifacts.yaml * Update release_publish_github_artifacts.yaml --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Luc Perkins <[email protected]> Co-authored-by: Gabriel Guerra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
This fixes an oversight in #291 where a new file (
gomod2nix.toml
) was added to the repo but not to the ignore list incodecov.yml
.Changes
Added
gomod2nix.toml
to the ignore list for code coverage checking.Related Issues
N/A
Testing
N/A
Screenshots (if applicable)
N/A
Checklist
Reviewers