-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(timers): enabling simple timers #308
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
==========================================
- Coverage 58.46% 57.82% -0.65%
==========================================
Files 113 113
Lines 9776 9794 +18
==========================================
- Hits 5716 5663 -53
- Misses 3693 3771 +78
+ Partials 367 360 -7 ☔ View full report in Codecov by Sentry. |
…an creating new column
Okay hear me out, not sure if this is possible... What if we define a stored column (similar to |
Going the tag route, move invocation to tags. |
Ready for review. |
Changes
This PR introduces a new
resonate:timeout
tag.Context
The new tag enables distinct behaviors between vanilla promises and simple timeout promises:
This distinction will allow events to be tied to the timeout of a promise.