Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct CompletePromise response code #374

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Conversation

dfarr
Copy link
Member

@dfarr dfarr commented Jul 26, 2024

for a timer promise: 403
for a regular promise: 403 if strict, otherwise 200

Fixes: #370
Fixes: #371
Fixes: #372
Fixes: #373

for a timer promise: 403
for a regular promise: 403 if strict, otherwise 200
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.86%. Comparing base (1218336) to head (5a7be38).

Files Patch % Lines
internal/app/coroutines/completePromise.go 37.50% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
- Coverage   55.88%   55.86%   -0.03%     
==========================================
  Files         124      124              
  Lines       10596    10601       +5     
==========================================
  Hits         5922     5922              
- Misses       4199     4201       +2     
- Partials      475      478       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfarr
Copy link
Member Author

dfarr commented Jul 27, 2024

@dfarr dfarr merged commit 32ed3d0 into main Jul 27, 2024
50 of 52 checks passed
@dfarr dfarr deleted the fix/complete-promise-status branch July 27, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DST: 3450 DST: 3450 DST: 23707 DST: 23707
1 participant