Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enqueue one task per root #458

Merged
merged 15 commits into from
Nov 14, 2024
Merged

Enqueue one task per root #458

merged 15 commits into from
Nov 14, 2024

Conversation

avillega
Copy link
Contributor

No description provided.

@avillega avillega requested a review from dfarr November 14, 2024 19:51
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 49.14286% with 89 lines in your changes missing coverage. Please review.

Project coverage is 55.33%. Comparing base (1577567) to head (1aa77ad).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/app/subsystems/aio/store/sqlite/sqlite.go 67.24% 17 Missing and 2 partials ⚠️
internal/app/coroutines/enqueueTasks.go 26.08% 17 Missing ⚠️
...rnal/app/subsystems/aio/store/postgres/postgres.go 69.64% 15 Missing and 2 partials ⚠️
pkg/task/record.go 0.00% 13 Missing ⚠️
test/dst/dst.go 0.00% 13 Missing ⚠️
internal/app/subsystems/aio/store/store.go 0.00% 7 Missing ⚠️
internal/kernel/t_aio/store.go 0.00% 2 Missing ⚠️
internal/app/coroutines/timeoutTasks.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
+ Coverage   55.22%   55.33%   +0.10%     
==========================================
  Files         119      119              
  Lines       13753    13876     +123     
==========================================
+ Hits         7595     7678      +83     
- Misses       5693     5730      +37     
- Partials      465      468       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avillega
Copy link
Contributor Author

I think this is finally ready.

Copy link
Member

@dfarr dfarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@avillega avillega merged commit 75f8b2a into main Nov 14, 2024
51 of 52 checks passed
@avillega avillega deleted the avillega/enque-one-task-per-root branch November 14, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants