Timeout promises before search request #70
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than switch the state of "logically timedout" promises at read time, we can timeout promises prior to searching. To do this we need ensure we still create the corresponding notifications, delete subscriptions, and update the promise all in one transaction.
This PR also changes the regular timeout promises coroutine to use the same logic as well as all complete promise coroutines to create notifications using the same logic.