Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to subscriptions #71

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

dfarr
Copy link
Member

@dfarr dfarr commented Sep 28, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #71 (cacda9b) into main (af6f469) will increase coverage by 0.00%.
The diff coverage is 91.66%.

@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   70.89%   70.90%           
=======================================
  Files          42       42           
  Lines        4247     4279   +32     
=======================================
+ Hits         3011     3034   +23     
- Misses       1019     1029   +10     
+ Partials      217      216    -1     
Files Coverage Δ
internal/app/coroutines/readSubscriptions.go 85.45% <100.00%> (+4.50%) ⬆️
internal/app/coroutines/searchPromises.go 89.47% <100.00%> (ø)
internal/app/subsystems/aio/store/test/util.go 75.75% <ø> (ø)
internal/kernel/types/api_request.go 97.40% <100.00%> (+0.43%) ⬆️
internal/kernel/types/api_response.go 79.48% <100.00%> (+0.26%) ⬆️
internal/kernel/types/cursor.go 22.50% <100.00%> (+22.50%) ⬆️
pkg/subscription/record.go 76.92% <100.00%> (+1.92%) ⬆️
pkg/subscription/subscription.go 100.00% <ø> (ø)
test/dst/generator.go 100.00% <100.00%> (ø)
...rnal/app/subsystems/aio/store/postgres/postgres.go 68.33% <83.33%> (-2.00%) ⬇️
... and 2 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dfarr dfarr merged commit 2e11176 into main Sep 28, 2023
4 checks passed
@dfarr dfarr deleted the feature/subscription-pagination branch September 28, 2023 20:31
@dfarr dfarr mentioned this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant