Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict mode and remove complete promise #73

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Conversation

dfarr
Copy link
Member

@dfarr dfarr commented Sep 29, 2023

If strict mode is set to false, a promise in any state (if idempotency keys match) is returned successfully to the client, otherwise the promise must be in the same state as the request.

If strict mode is set to false, a promise in any state (if
idempotency keys match) is returned successfully to the client,
otherwise the promise must be in the same state as the request.
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #73 (02e858f) into main (09f6ff0) will increase coverage by 0.97%.
The diff coverage is 76.82%.

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   69.82%   70.80%   +0.97%     
==========================================
  Files          42       41       -1     
  Lines        4302     4114     -188     
==========================================
- Hits         3004     2913      -91     
+ Misses       1084      990      -94     
+ Partials      214      211       -3     
Files Coverage Δ
internal/aio/aio_dst.go 65.30% <100.00%> (+1.47%) ⬆️
internal/app/coroutines/createPromise.go 70.07% <100.00%> (+0.72%) ⬆️
internal/kernel/types/api_request.go 97.29% <100.00%> (-0.11%) ⬇️
internal/kernel/types/api_response.go 77.77% <ø> (-1.71%) ⬇️
test/dst/dst.go 93.24% <ø> (-0.27%) ⬇️
test/dst/generator.go 100.00% <100.00%> (ø)
internal/app/coroutines/cancelPromise.go 72.90% <80.00%> (ø)
internal/app/coroutines/rejectPromise.go 72.90% <80.00%> (ø)
internal/app/coroutines/resolvePromise.go 72.72% <80.00%> (ø)
test/dst/model.go 57.85% <61.90%> (+2.55%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dfarr dfarr merged commit 74a435d into main Sep 29, 2023
4 checks passed
@dfarr dfarr deleted the feature/strict-mode branch September 29, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant