Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor idempotency key #74

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Refactor idempotency key #74

merged 3 commits into from
Oct 2, 2023

Conversation

dfarr
Copy link
Member

@dfarr dfarr commented Sep 30, 2023

param_ikey -> idempotency_key_for_create
value_ikey -> idempotency_key_for_complete

param_ikey -> idempotency_key_for_create
value_ikey -> idempotency_key_for_complete
@dfarr
Copy link
Member Author

dfarr commented Sep 30, 2023

Todo:

  • update promise.proto
  • fix dst

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #74 (ac51c87) into main (74a435d) will decrease coverage by 0.01%.
The diff coverage is 75.94%.

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   70.80%   70.80%   -0.01%     
==========================================
  Files          41       41              
  Lines        4114     4131      +17     
==========================================
+ Hits         2913     2925      +12     
- Misses        990      995       +5     
  Partials      211      211              
Files Coverage Δ
internal/app/coroutines/timeoutPromise.go 84.90% <ø> (-0.28%) ⬇️
...rnal/app/subsystems/aio/store/postgres/postgres.go 68.63% <100.00%> (ø)
internal/app/subsystems/aio/store/sqlite/sqlite.go 70.74% <100.00%> (ø)
internal/app/subsystems/aio/store/test/util.go 75.75% <100.00%> (ø)
internal/kernel/types/api_request.go 97.29% <100.00%> (ø)
pkg/promise/promise.go 63.79% <100.00%> (+1.29%) ⬆️
pkg/promise/record.go 67.85% <100.00%> (ø)
test/dst/generator.go 100.00% <100.00%> (ø)
internal/app/coroutines/cancelPromise.go 72.95% <72.72%> (+0.05%) ⬆️
internal/app/coroutines/createPromise.go 70.00% <70.00%> (-0.08%) ⬇️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dfarr dfarr merged commit 16c30a7 into main Oct 2, 2023
3 of 4 checks passed
@dfarr dfarr deleted the refactor/ikey branch October 2, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant