Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags and createdOn/completedOn timestamps to promises #9

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

dfarr
Copy link
Member

@dfarr dfarr commented Aug 30, 2023

Closes #6
Closes #7

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #9 (44ae889) into main (4f1f006) will increase coverage by 1.03%.
The diff coverage is 88.42%.

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   75.03%   76.06%   +1.03%     
==========================================
  Files          39       39              
  Lines        3264     3317      +53     
==========================================
+ Hits         2449     2523      +74     
+ Misses        666      647      -19     
+ Partials      149      147       -2     
Files Changed Coverage Δ
internal/aio/aio.go 0.00% <0.00%> (ø)
internal/kernel/types/api_request.go 96.36% <ø> (ø)
pkg/promise/promise.go 94.59% <ø> (ø)
pkg/subscription/subscription.go 100.00% <ø> (ø)
internal/app/coroutines/readPromise.go 81.01% <64.28%> (+5.10%) ⬆️
internal/app/subsystems/aio/store/sqlite/sqlite.go 71.15% <73.33%> (+0.03%) ⬆️
internal/app/coroutines/timeoutPromise.go 88.23% <75.00%> (+0.14%) ⬆️
pkg/promise/record.go 67.27% <75.00%> (-2.73%) ⬇️
internal/app/coroutines/createPromise.go 83.75% <83.33%> (+3.10%) ⬆️
internal/app/coroutines/resolvePromise.go 86.26% <95.65%> (+2.56%) ⬆️
... and 14 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dfarr dfarr merged commit 8a7247f into main Aug 31, 2023
3 checks passed
@dfarr dfarr deleted the feature/times-and-tags branch August 31, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tags Add CreatedOn and CompletedOn fields
1 participant