Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(contributing): set contribution expectations #91

Merged
merged 3 commits into from
Nov 2, 2023
Merged

doc(contributing): set contribution expectations #91

merged 3 commits into from
Nov 2, 2023

Conversation

guergabo
Copy link
Contributor

@guergabo guergabo commented Oct 29, 2023

Doc aims to establish an entry point for new contributors. Assumptions were made for areas of contributions. @dfarr lmk what you think. Anything missing?

adde echo cause its too cool not to.

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #91 (a437512) into main (a819787) will decrease coverage by 0.10%.
Report is 1 commits behind head on main.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   64.54%   64.44%   -0.10%     
==========================================
  Files          55       55              
  Lines        5816     5828      +12     
==========================================
+ Hits         3754     3756       +2     
- Misses       1786     1795       +9     
- Partials      276      277       +1     
Files Coverage Δ
internal/api/api.go 68.03% <36.36%> (-5.61%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@guergabo guergabo marked this pull request as ready for review October 29, 2023 02:09
Copy link
Member

@dfarr dfarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, love including the logo!

@guergabo guergabo merged commit 53d3775 into resonatehq:main Nov 2, 2023
2 of 4 checks passed
@guergabo guergabo deleted the guergabo/contribute branch November 2, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants