Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tour java improvements #205

Merged
merged 9 commits into from
Dec 12, 2023
Merged

Tour java improvements #205

merged 9 commits into from
Dec 12, 2023

Conversation

gvdongen
Copy link
Contributor

  • Incorporated Till's feedback (also fixing pre-release workflow)
  • Cleaned up code Java snippets (mainly the calls)
  • Improved the JavaTour text
  • Added state introspection via psql instead of printing

Copy link

cloudflare-workers-and-pages bot commented Dec 12, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: de5c8e4
Status:🚫  Build failed.

View logs

Copy link
Contributor

@pcholakov pcholakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions but overall looking great! 👏

docs/tour.mdx Outdated Show resolved Hide resolved
docs/tour.mdx Outdated Show resolved Hide resolved
docs/tour.mdx Outdated Show resolved Hide resolved
@pcholakov
Copy link
Contributor

I recently discovered the curl --json flag - it means we can shorten example requests to something like:

curl http://localhost:8080/example.UserSession/ExpireTicket --json '{"user_id": "123", "ticket_id":"456"}'

Up to you if you want to replace all the occurrences; either way it's a copy-paste operation for the reader.

@slinkydeveloper
Copy link
Contributor

@pcholakov I remember there was some concern with --json: #31

gvdongen and others added 3 commits December 12, 2023 16:00
Co-authored-by: Pavel Tcholakov <[email protected]>
Co-authored-by: Pavel Tcholakov <[email protected]>
Co-authored-by: Pavel Tcholakov <[email protected]>
@gvdongen gvdongen merged commit f22b796 into tour_java Dec 12, 2023
1 check failed
@gvdongen gvdongen deleted the tour_java_improvements branch December 12, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants