Golang docs #442
Golang docs #442
Conversation
Deploying documentation with
|
| Latest commit: |
4bb79f3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://63e8676d.documentation-beg.pages.dev |
| Branch Preview URL: | https://golang.documentation-beg.pages.dev |
|
|
||
| Request-response calls are requests where the client waits for the response. | ||
|
|
||
| <CH.Scrollycoding className={"single-item"}> |
There was a problem hiding this comment.
there is a problem with tab here, not sure what
There was a problem hiding this comment.
not sure what you mean
There was a problem hiding this comment.
There was a problem hiding this comment.
A lot of space taken there for the text on the left, could be used by the code
|
I have one general comment that the indentation is too much... e.g. this:
Compared to this:
This is especially visible in snippets with fairly long-ish lines... Can you configure go fmt to use 2 spaces instead of 4? |
|
I think the checking of the go code snippets still needs to be added to the github workflows as well |
|
And we should add Go icons to the overview page here: https://golang.documentation-beg.pages.dev/ |
|
@slinkydeveloper go uses tabs, i will check how to get our code blocks to display them tighter |
Co-authored-by: Francesco Guardiani <[email protected]>
The best way to review this is just to look at the preview