Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy using Knative #62

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Deploy using Knative #62

merged 4 commits into from
Jul 12, 2023

Conversation

slinkydeveloper
Copy link
Contributor

Fix #51

gvdongen
gvdongen approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@gvdongen gvdongen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments but looks good! I will try this out for the shopping cart demo.

docs/deployment-operations/deployment.md Outdated Show resolved Hide resolved
docs/deployment-operations/deployment.md Outdated Show resolved Hide resolved
@slinkydeveloper slinkydeveloper mentioned this pull request Jul 12, 2023
Closed
@slinkydeveloper slinkydeveloper merged commit 641fd86 into main Jul 12, 2023
@slinkydeveloper slinkydeveloper deleted the issues/51 branch July 12, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvdongen gvdongen gvdongen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Service endpoint deployment with Knative
2 participants
@slinkydeveloper @gvdongen